[filechooser] Free things which got duplicated or reffed by gtk_tree_model_get()

We had forgotten to do that in a few places; this is a systematic search for those.

https://bugzilla.gnome.org/show_bug.cgi?id=646461

diff --git a/gtk/gtkfilechooserbutton.c b/gtk/gtkfilechooserbutton.c
index 8b917fb3034e365ec9fa15f6b80e69cc7ca8bd2f..c12ef917f049808faed3b8465f23d90e86ea7275 100644 (file)
--- a/gtk/gtkfilechooserbutton.c
+++ b/gtk/gtkfilechooserbutton.c
@@ -1551,7 +1551,10 @@ model_free_row_data (GtkFileChooserButton *button,
                      -1);
 
   if (cancellable)
-    g_cancellable_cancel (cancellable);
+    {
+      g_cancellable_cancel (cancellable);
+      g_object_unref (cancellable);
+    }
 
   switch (type)
     {

diff --git a/gtk/gtkfilechooserdefault.c b/gtk/gtkfilechooserdefault.c
index 2022a3d2d81c6bda70890ab281138d175999f3f8..b5e46d5ba6939493ecdfa2848fab383a424a80c5 100644 (file)
--- a/gtk/gtkfilechooserdefault.c
+++ b/gtk/gtkfilechooserdefault.c
@@ -3195,7 +3195,7 @@ shortcuts_reorder (GtkFileChooserDefault *impl,
   int bookmarks_index;
   GFile *file;
   GError *error;
-  gchar *name;
+  gchar *name = NULL;
 
   /* Get the selected path */
 
@@ -3241,6 +3241,7 @@ shortcuts_reorder (GtkFileChooserDefault *impl,
  out:
 
   g_object_unref (file);
+  g_free (name);
 }
 
 /* Callback used when we get the drag data for the bookmarks list.  We add the
@@ -10035,6 +10036,7 @@ list_row_activated (GtkTreeView           *tree_view,
   if (is_folder && file)
     {
       change_folder_and_display_error (impl, file, FALSE);
+      g_object_unref (file);
       goto out;
     }
 

diff --git a/gtk/gtkfilechooserentry.c b/gtk/gtkfilechooserentry.c
index 4ac71ed5f702699d5a888ffb097fd577903b1f26..d0d043fcd03b3f68205060cb15e1c2f4ba4b0e7a 100644 (file)
--- a/gtk/gtkfilechooserentry.c
+++ b/gtk/gtkfilechooserentry.c
@@ -336,8 +336,9 @@ match_selected_callback (GtkEntryCompletion  *completion,
 
   if (!display_name || !file)
     {
-      /* these shouldn't complain if passed NULL */
-      g_object_unref (file);
+      if (file)
+       g_object_unref (file);
+
       g_free (display_name);
       return FALSE;
     }